Skip to content
This repository has been archived by the owner on Oct 15, 2019. It is now read-only.

Hide Brave Rewards Icon #203

Closed
anthonypkeane opened this issue Sep 5, 2019 · 6 comments · Fixed by brave/brave-ios#1567
Closed

Hide Brave Rewards Icon #203

anthonypkeane opened this issue Sep 5, 2019 · 6 comments · Fixed by brave/brave-ios#1567
Assignees
@kylehickinson
Labels
brave-ios An issue that will be resolved by some work in brave-ios
Milestone
Rewards and Ads o...

Comments

@anthonypkeane
Copy link

In Settings, under OTHER SETTINGS, Sync, Brave Rewards, add a section called Display & Appearance

Here add the following:

Hide Brave Regards Icon
(sub text) Hides the Brave Rewards icon when Brave Rewards is not enabled

Toggle Switch On | Off
Default off

(see Android for formatting)

The option should be grey'ed out if Brave Rewards is enabled

Also,
Move Show Bookmark Shortcut into Display & Appearance and place it above Hide Brave Regards Icon

i.e.

Display & Appearance

Show Bookmark Shortcut
Hide Brave Regards Icon
@anthonypkeane anthonypkeane added this to the Rewards and Ads on iOS milestone Sep 5, 2019
@kylehickinson
Copy link
Collaborator

kylehickinson commented Sep 6, 2019 •
edited
Loading

@anthonypkeane Please add a screenshot of Android implementation

@anthonypkeane anthonypkeane self-assigned this Sep 6, 2019
@tmancey tmancey changed the title Hide Brave Regards Icon Hide Brave Rewards Icon Sep 12, 2019
@kylehickinson kylehickinson added blocked Work on this issue cannot be started until certain issues are closed needs design Needs design work before it can be done labels Sep 17, 2019
@anthonypkeane
Copy link
Author

anthonypkeane commented Sep 18, 2019 •
edited
Loading

UPDATE

In Settings > Display & Brightness add the following under Display & Brightness

Show Bookmarks Shortcut (brave/brave-ios#1391)
Just move in here

Hide Brave Regards Icon
(sub text) Hides the Brave Rewards icon when Brave Rewards is not enabled

Toggle Switch On | Off
Default off

@jamesmudgett can you please confirm?

@kylehickinson kylehickinson added the brave-ios An issue that will be resolved by some work in brave-ios label Sep 18, 2019
@kylehickinson
Copy link
Collaborator

@anthonypkeane

You want the Show Bookmarks Shortcut put inside the Display & Brightness menu?

image

@anthonypkeane
Copy link
Author

Confirming

Settings
General

Display
    Brightness 
    Show Tabs Bar
    Show Bookmarks Shortcut
    Hide Brave Rewards Icon

Brightness = the Automatic/Light/Dark options

@anthonypkeane anthonypkeane removed blocked Work on this issue cannot be started until certain issues are closed needs design Needs design work before it can be done labels Sep 18, 2019
@jhreis
Copy link

jhreis commented Sep 18, 2019

Maybe we should follow Apple and call it "Appearance" instead of "brightness". Will almost certainly be weird if we diverge our brightness meaning from what iOS uses.

@anthonypkeane
Copy link
Author

Appearance sounds fine with me

kylehickinson added a commit to brave/brave-ios that referenced this issue Sep 19, 2019
@kylehickinson
Rewards: Add "Hide Rewards Icon" setting to new Display settings section
51c7eef 
Fixes brave/brave-rewards-ios#203
@kylehickinson kylehickinson mentioned this issue Sep 19, 2019
Merged
7 tasks
kylehickinson added a commit to brave/brave-ios that referenced this issue Sep 19, 2019
@kylehickinson
Rewards: Add "Hide Rewards Icon" setting to new Display settings sect…
3960a25 
…ion (#1567)

Fixes brave/brave-rewards-ios#203
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
brave-ios An issue that will be resolved by some work in brave-ios
Projects
None yet
Milestone
Rewards and Ads on iOS
Development

Successfully merging a pull request may close this issue.

Rewards: Add "Hide Rewards Icon" setting to new Display settings section brave/brave-ios
3 participants
@kylehickinson @jhreis @anthonypkeane