Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Rewards: Add "Hide Rewards Icon" setting to new Display settings section #1567

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

kylehickinson
Copy link
Collaborator

Fixes brave/brave-rewards-ios#203

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Prefix: Enable rewards by removing the NO_REWARDS build flag
  • Verify that rewards is disabled/wallet not created
  • Open settings, verify that new display section looks correct and settings within it work as usual
  • Turn on Hide Brave Rewards Icon and close settings, verify that the icon is no longer in the toolbar
  • Verify that icon stays hidden through app launches
  • Turn off Hide Brave Rewards Icon and enable Brave Rewards in the panel
  • Turn on Hide Brave Rewards Icon again and verify that the icon is still visible in the toolbar since BR is enabled

Screenshots:

Simulator Screen Shot - iPhone Xs - 2019-09-19 at 11 07 11

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@kylehickinson
Copy link
Collaborator Author

This needs a transfix push btw

@kylehickinson kylehickinson merged commit 3960a25 into development Sep 19, 2019
@kylehickinson kylehickinson deleted the hide-rewards-icon branch September 19, 2019 20:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide Brave Rewards Icon
2 participants