Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #8009: Update toolbar constraints to utilize safe area properly #8084

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

kylehickinson
Copy link
Collaborator

The value of UIApplication.shared.keyWindow?.safeAreaInsets.bottom is not updated when the updateViewConstraints method is called. However calculating this height manually is not correct/not needed, as we can simply rely on the safe area layout guides

Bonus: UIApplication.shared.keyWindow is actually deprecated, so 1 less usage of this now exists in the codebase

Summary of Changes

This pull request fixes #8009

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

The value of `UIApplication.shared.keyWindow?.safeAreaInsets.bottom` is not updated when the `updateViewConstraints` method is called. However calculating this height manually is not correct/not needed, as we can simply rely on the safe area layout guides
@kylehickinson kylehickinson requested a review from a team as a code owner September 18, 2023 19:20
@kylehickinson kylehickinson added this to the 1.59 milestone Sep 18, 2023
@kylehickinson kylehickinson enabled auto-merge (squash) September 18, 2023 19:30
@kylehickinson kylehickinson merged commit f90d858 into development Sep 18, 2023
@kylehickinson kylehickinson deleted the toolbar-height-rotate-fix branch September 18, 2023 21:04
cuba added a commit that referenced this pull request Nov 6, 2023
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
…area properly (brave/brave-ios#8084)

The value of `UIApplication.shared.keyWindow?.safeAreaInsets.bottom` is not updated when the `updateViewConstraints` method is called. However calculating this height manually is not correct/not needed, as we can simply rely on the safe area layout guides
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI is shrunk on the bottom part of the toolbar when "Tabs Bar" is set to "Landscape only"
2 participants