This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #8009: Update toolbar constraints to utilize safe area properly #8084
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The value of
UIApplication.shared.keyWindow?.safeAreaInsets.bottom
is not updated when theupdateViewConstraints
method is called. However calculating this height manually is not correct/not needed, as we can simply rely on the safe area layout guidesBonus:
UIApplication.shared.keyWindow
is actually deprecated, so 1 less usage of this now exists in the codebaseSummary of Changes
This pull request fixes #8009
Submitter Checklist:
NSLocalizableString()
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement