You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 10, 2024. It is now read-only.
UI is shrunk on the bottom part of the toolbar when Tabs Bar is set to Landscape only after device rotation. This issue was observed for both Top Bar and Bottom Bar.
Steps to Reproduce
Launch Brave
Three-dot menu > Settings
Find TABS section > Select Top Bar or Bottom Bar (it doesn't matter which option is selected)
Open Tabs Bar > Select Landscape Only
Go back and open more than 1 tab
Now rotate the device to Landscape mode and then back to Portrait mode > Observe the issue
Actual result:
UI is shrunk on the bottom part of the toolbar when Tabs Bar is set to Landscape only after device rotation. This issue was observed for both Top Bar and Bottom Bar and is happening only when more then one tab is opened.
Bottom Bar
1
2
Top Bar
1
2
Expected result:
UI must not shrink.
Reproduces how often: [Easily reproduced, Intermittent Issue]
The value of `UIApplication.shared.keyWindow?.safeAreaInsets.bottom` is not updated when the `updateViewConstraints` method is called. However calculating this height manually is not correct/not needed, as we can simply rely on the safe area layout guides
…8084)
The value of `UIApplication.shared.keyWindow?.safeAreaInsets.bottom` is not updated when the `updateViewConstraints` method is called. However calculating this height manually is not correct/not needed, as we can simply rely on the safe area layout guides
…area properly (brave/brave-ios#8084)
The value of `UIApplication.shared.keyWindow?.safeAreaInsets.bottom` is not updated when the `updateViewConstraints` method is called. However calculating this height manually is not correct/not needed, as we can simply rely on the safe area layout guides
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Description:
UI is shrunk on the bottom part of the toolbar when
Tabs Bar
is set toLandscape only
after device rotation. This issue was observed for bothTop Bar
andBottom Bar
.Steps to Reproduce
TABS
section > SelectTop Bar
orBottom Bar
(it doesn't matter which option is selected)Tabs Bar
> SelectLandscape Only
Landscape mode
and then back toPortrait mode
> Observe the issueActual result:
UI is shrunk on the bottom part of the toolbar when
Tabs Bar
is set toLandscape only
after device rotation. This issue was observed for bothTop Bar
andBottom Bar
and is happening only when more then one tab is opened.Bottom Bar
Top Bar
Expected result:
UI must not shrink.
Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily reproduced
Brave Version:
Brave build: 1.57 (23.8.29.22)
BraveCore: 1.57.53 (116.0.5845.114)
Device details:
iPhone 14 [iOS 17.0]
Website problems only:
Additional Information
The text was updated successfully, but these errors were encountered: