Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

UI is shrunk on the bottom part of the toolbar when "Tabs Bar" is set to "Landscape only" #8009

Closed
hffvld opened this issue Aug 31, 2023 · 1 comment · Fixed by #8084
Closed

Comments

@hffvld
Copy link
Collaborator

hffvld commented Aug 31, 2023

Description:

UI is shrunk on the bottom part of the toolbar when Tabs Bar is set to Landscape only after device rotation. This issue was observed for both Top Bar and Bottom Bar.

Steps to Reproduce

  1. Launch Brave
  2. Three-dot menu > Settings
  3. Find TABS section > Select Top Bar or Bottom Bar (it doesn't matter which option is selected)
  4. Open Tabs Bar > Select Landscape Only
  5. Go back and open more than 1 tab
  6. Now rotate the device to Landscape mode and then back to Portrait mode > Observe the issue

Actual result:

UI is shrunk on the bottom part of the toolbar when Tabs Bar is set to Landscape only after device rotation. This issue was observed for both Top Bar and Bottom Bar and is happening only when more then one tab is opened.

Bottom Bar

1 2
1 2

Top Bar

1 2
1 2

Expected result:

UI must not shrink.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.57 (23.8.29.22)
BraveCore: 1.57.53 (116.0.5845.114)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
  • Can you reproduce this issue with the current build from AppStore? Yes

Device details:

iPhone 14 [iOS 17.0]

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

kylehickinson added a commit that referenced this issue Sep 18, 2023
The value of `UIApplication.shared.keyWindow?.safeAreaInsets.bottom` is not updated when the `updateViewConstraints` method is called. However calculating this height manually is not correct/not needed, as we can simply rely on the safe area layout guides
kylehickinson added a commit that referenced this issue Sep 18, 2023
…8084)

The value of `UIApplication.shared.keyWindow?.safeAreaInsets.bottom` is not updated when the `updateViewConstraints` method is called. However calculating this height manually is not correct/not needed, as we can simply rely on the safe area layout guides
@kylehickinson kylehickinson added this to the 1.59 milestone Sep 19, 2023
cuba added a commit that referenced this issue Nov 6, 2023
@hffvld
Copy link
Collaborator Author

hffvld commented Nov 7, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.1
Brave build: 1.60 (23.11.4.14)
BraveCore: 1.60.105 (119.0.6045.59)

STEPS:

  1. Followed the steps from UI is shrunk on the bottom part of the toolbar when "Tabs Bar" is set to "Landscape only" #8009 (comment)

ACTUAL RESULTS:

  • Verified that the bottom bar UI is not shrunk after device rotation.

RPReplay_Final1699380387.mp4

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
…area properly (brave/brave-ios#8084)

The value of `UIApplication.shared.keyWindow?.safeAreaInsets.bottom` is not updated when the `updateViewConstraints` method is called. However calculating this height manually is not correct/not needed, as we can simply rely on the safe area layout guides
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants