Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7855: Add 'Private tabs' settings section #7868

Merged
merged 7 commits into from
Aug 15, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Aug 10, 2023

Summary of Changes

This PR also organize and arrange the views and controller to desired folders for settings.

This pull request fixes #7855

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Verify Private tabs under Tab section
  • Verify Private tabs include Persistent Private Tabs toggle and Local Authentication Toggle
  • Verify toggles are working as intended

QA: Search for Private Tab Mode Local Authentication Cases for additional information about cases

Screenshots:

RPReplay_Final1692029428.MP4

111

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel self-assigned this Aug 10, 2023
@soner-yuksel soner-yuksel requested a review from a team as a code owner August 10, 2023 20:50
@soner-yuksel soner-yuksel added this to the 1.57 milestone Aug 14, 2023
@soner-yuksel soner-yuksel force-pushed the enhancement/settings-private-tabs branch from 2843d78 to cdfc037 Compare August 14, 2023 16:13
@soner-yuksel soner-yuksel requested a review from Brandon-T August 15, 2023 18:37
@soner-yuksel soner-yuksel force-pushed the enhancement/settings-private-tabs branch from 01cf106 to 1cc9050 Compare August 15, 2023 18:39
@soner-yuksel soner-yuksel requested a review from Brandon-T August 15, 2023 19:25
@soner-yuksel soner-yuksel merged commit ddcbec2 into development Aug 15, 2023
@soner-yuksel soner-yuksel deleted the enhancement/settings-private-tabs branch August 15, 2023 19:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'Private tabs' settings section
2 participants