This repository has been archived by the owner on May 10, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 442
Fix #7855: Add 'Private tabs' settings section #7868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
soner-yuksel
force-pushed
the
enhancement/settings-private-tabs
branch
from
August 14, 2023 16:13
2843d78
to
cdfc037
Compare
Brandon-T
suggested changes
Aug 15, 2023
soner-yuksel
force-pushed
the
enhancement/settings-private-tabs
branch
from
August 15, 2023 18:39
01cf106
to
1cc9050
Compare
Brandon-T
suggested changes
Aug 15, 2023
Brandon-T
approved these changes
Aug 15, 2023
This was referenced Aug 18, 2023
arthuredelstein
pushed a commit
to brave/brave-core
that referenced
this pull request
Feb 13, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR also organize and arrange the views and controller to desired folders for settings.
This pull request fixes #7855
Submitter Checklist:
NSLocalizableString()
Test Plan:
QA: Search for
Private Tab Mode Local Authentication Cases
for additional information about casesScreenshots:
RPReplay_Final1692029428.MP4
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement