Pull Request comments are addressed

brave · Aug 15, 2023 · 01cf106 · 01cf106
1 parent cdfc037
commit 01cf106
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/Sources/Brave/Frontend/Settings/Shields/OptionToggleView.swift b/Sources/Brave/Frontend/Settings/Shields/OptionToggleView.swift
@@ -13,7 +13,7 @@ struct OptionToggleView: View {
   @ObservedObject var option: Preferences.Option<Bool>
   let onChange: ShieldToggleView.OnChangeCallback?
 
-  init(title: String, subtitle: String? = nil,
+  init(title: String, subtitle: String?,
        option: Preferences.Option<Bool>, onChange: ShieldToggleView.OnChangeCallback? = nil) {
     self.title = title
     self.subtitle = subtitle

diff --git a/Sources/Brave/Frontend/Settings/Tabs/PrivateTabsView.swift b/Sources/Brave/Frontend/Settings/Tabs/PrivateTabsView.swift
@@ -68,6 +68,7 @@ struct PrivateTabsView: View {
         footer: privateBrowsingOnly.value ? Text("") : Text(Strings.TabsSettings.persistentPrivateBrowsingDescription)) {
         if !privateBrowsingOnly.value {
           OptionToggleView(title: Strings.TabsSettings.persistentPrivateBrowsingTitle,
+                           subtitle: nil,
                            option: Preferences.Privacy.persistentPrivateBrowsing) { newValue in
             Task { @MainActor in
               if newValue {
@@ -88,6 +89,7 @@ struct PrivateTabsView: View {
         switch localAuthenticationType {
         case .faceID, .touchID, .pinCode:
           OptionToggleView(title: browsingLockTitle,
+                           subtitle: nil,
                            option: Preferences.Privacy.privateBrowsingLock)
         case .noAuthentication:
           Toggle(isOn: .constant(false)) {