Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7836: Tabs Bar not updating when opening bulk bookmarks #7850

Merged
merged 1 commit into from
Aug 9, 2023

Conversation

Brandon-T
Copy link
Collaborator

@Brandon-T Brandon-T commented Aug 8, 2023

Summary of Changes

  • Update the tabs url when opening bulk tabs. Not exactly sure why this delegate was never implemented, but we either implement it or we call selectTab before .isRestoring = false instead of isRestoring = false then selectTab.

This pull request fixes #7836

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@Brandon-T Brandon-T added this to the 1.57 milestone Aug 8, 2023
@Brandon-T Brandon-T self-assigned this Aug 8, 2023
@Brandon-T Brandon-T requested a review from a team as a code owner August 8, 2023 19:14
@iccub iccub merged commit 56bf475 into development Aug 9, 2023
7 checks passed
@iccub iccub deleted the bugfix/TopToolBarTabs branch August 9, 2023 12:55
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Opening of multiple bookmarks shows only last bookmark
3 participants