Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Opening of multiple bookmarks shows only last bookmark #7836

Closed
parsd51 opened this issue Aug 7, 2023 · 1 comment · Fixed by #7850
Closed

Opening of multiple bookmarks shows only last bookmark #7836

parsd51 opened this issue Aug 7, 2023 · 1 comment · Fixed by #7850

Comments

@parsd51
Copy link

parsd51 commented Aug 7, 2023

Description:

Opening of multiple bookmarks shows only last bookmark (with wrong header)

Steps to Reproduce

  1. Have one or more tabs open, in my example one new tab is open (tab A)
  2. Select bookmarks from icon next to url/input line, or via menu.
  3. Longpress a folder with bookmarks (in my case six)
  4. Press ‘Open all’

Actual result:

Tab A’s header is shown along with the last bookmark content in the list.
A tab on tab A’s header opens all selected tabs with tab A highlighted.

Expected result:

All six bookmarks should open with the last bookmark in the list active.

Reproduces how often: [Easily reproduced, Intermittent Issue]

100%

Brave Version:

Brave Version 1.56 (23.8.4.21) (released version)

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

Ipad Air 4, IpadOS 16.6

Website problems only:

  • did you check with Brave Shields down? Yes, same problem
  • did you check in Safari/Firefox (WkWebView-based browsers)? N/A

Additional Information

@parsd51 parsd51 changed the title Opening of multiple tabs shows only last bookmark Opening of multiple bookmarks shows only last bookmark Aug 7, 2023
@Brandon-T Brandon-T self-assigned this Aug 8, 2023
@Brandon-T Brandon-T added this to the 1.57 milestone Aug 8, 2023
@hffvld
Copy link
Collaborator

hffvld commented Aug 22, 2023

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 [iOS 16.6]
- iPad Air [iPadOS 16.5.1]
Brave build: 1.57 (23.8.21.22)
BraveCore: 1.57.47 (116.0.5845.96)

iPhone - PASS

STEPS:

  1. Launch Brave
  2. Three-dot menu > Settings > Find TABS section > Top Bar is ON > Tabs Bar is OFF
  3. Go back and open at least 2 tabs
  4. Open Bookmarks from the button next to the URL search bar or from the Three-dot menu
  5. Choose the folder that contains at least 2 saved websites > Tap and hold on it > Open all > Done > Verify
  6. Return to Settings > Find TABS section > Top Bar is ON > Tabs Bar is ON
  7. Repeat Steps 3 - 5 > Verify
  8. Return to Settings > Find TABS section > Top Bar is ON > Tabs Bar is set to Landscape Only
  9. Repeat Steps 3 - 5 > Verify
  10. Return to Settings > Find TABS section > Bottom Bar is ON > Tabs Bar is OFF
  11. Repeat Steps 3 - 5 > Verify
  12. Return to Settings > Find TABS section > Bottom Bar is ON > Tabs Bar is ON
  13. Repeat Steps 3 - 5 > Verify
  14. Return to Settings > Find TABS section > Bottom Bar is ON > Tabs Bar is set to Landscape Only
  15. Repeat Steps 3 - 5 > Verify

ACTUAL RESULTS:

  • Verified that the tab header and currently shown tab both are correct
  • Verified that all bookmarked tabs are opened, and the last bookmark on the list is on the active tab

Top Bar is ON > Tabs Bar is OFF

RPReplay_Final1692734626.mp4

Top Bar is ON > Tabs Bar is ON

RPReplay_Final1692734839.mp4

Top Bar is ON > Tabs Bar is Landscape Only

RPReplay_Final1692735675.mp4

Bottom Bar is ON > Tabs Bar is OFF

RPReplay_Final1692735111.mp4

Bottom Bar is ON > Tabs Bar is ON

RPReplay_Final1692736036.mp4

Bottom Bar is ON > Tabs Bar is Landscape Only

RPReplay_Final1692736098.mp4
iPad - PASS

STEPS:

  1. Launch Brave
  2. Three-dot menu > Settings > Find TABS section > Make sure Tabs Bar is ON
  3. Go back and open at least 2 tabs
  4. Open Bookmarks from the button next to the URL search bar or from the Three-dot menu
  5. Choose the folder that contains at least 2 saved websites > Tap and hold on it > Open all > Done > Verify
  6. Now open Settings again > TABS section > Turn OFF Tabs Bar
  7. Repeat Steps 3 - 5 > Verify

ACTUAL RESULTS:

  • Verified that the tab header and currently shown tab both are correct
  • Verified that all bookmarked tabs are opened, and the last bookmark on the list is on the active tab

Tabs Bar is ON

RPReplay_Final1692731016.mp4

Tabs Bar is OFF

RPReplay_Final1692732065.mp4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants