Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7846: Ensure Ads enabled pref is updated correctly when disabling #7847

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

kylehickinson
Copy link
Collaborator

This was moved in a 1.57 core bump for the enabling path but missed for the disabling path

Summary of Changes

This pull request fixes #7846

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

This was moved in a 1.57 core bump for the enabling path but missed for the disabling path
@kylehickinson kylehickinson added this to the 1.57 milestone Aug 8, 2023
@kylehickinson kylehickinson requested a review from a team as a code owner August 8, 2023 16:18
@kylehickinson kylehickinson enabled auto-merge (squash) August 8, 2023 16:23
@kylehickinson kylehickinson merged commit a2fea99 into development Aug 8, 2023
@kylehickinson kylehickinson deleted the fix-rewards-disable branch August 8, 2023 16:40
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
…y when disabling (brave/brave-ios#7847)

This was moved in a 1.57 core bump for the enabling path but missed for the disabling path
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewards/Ads can't be disabled
2 participants