Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Rewards/Ads can't be disabled #7846

Closed
kylehickinson opened this issue Aug 8, 2023 · 1 comment · Fixed by #7847
Closed

Rewards/Ads can't be disabled #7846

kylehickinson opened this issue Aug 8, 2023 · 1 comment · Fixed by #7847
Assignees
@kylehickinson
Labels
bug Epic: Rewards QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.57

Comments

@kylehickinson
Copy link
Collaborator

Description:

Rewards/Ads can't be disabled via the Rewards panel in 1.57+
@kylehickinson kylehickinson added this to the 1.57 milestone Aug 8, 2023
@kylehickinson kylehickinson self-assigned this Aug 8, 2023
kylehickinson added a commit that referenced this issue Aug 8, 2023
@kylehickinson
Fix #7846: Ensure Ads enabled pref is updated correctly when disabling
b0717a6 
This was moved in a 1.57 core bump for the enabling path but missed for the disabling path
@kylehickinson kylehickinson mentioned this issue Aug 8, 2023
Merged
11 tasks
kylehickinson added a commit that referenced this issue Aug 8, 2023
@kylehickinson
Fix #7846: Ensure Ads enabled pref is updated correctly when disabling (
a2fea99 
#7847)

This was moved in a 1.57 core bump for the enabling path but missed for the disabling path
@Uni-verse
Copy link
Contributor

Uni-verse commented Aug 21, 2023 •
edited
Loading

Verified on iPhone X running iOS 16.5.1 using version 1.57 (23.8.18.20)

Case: Fresh Profile
  • Ensured Brave Rewards toggle can be disabled via the panel after enabling on fresh profile.
  • Ensured Toggle in Brave Rewards menu can be disabled.
Example Example
IMG_3464 2 IMG_3465 2
Case Existing Profile
  • Ensured Brave Rewards toggle can be disabled after enabling Rewards on 1.56.x and then upgrading to 1.57.x
  • Ensured Brave Rewards toggle can be disabled if Rewards was enabled after upgrading to 1.57.x.

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@kylehickinson
Fix brave/brave-ios#7846: Ensure Ads enabled pref is updated correctl…
cb6bdf1 
…y when disabling (brave/brave-ios#7847)

This was moved in a 1.57 core bump for the enabling path but missed for the disabling path
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: Rewards QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.57
Development

Successfully merging a pull request may close this issue.

Fix #7846: Ensure Ads enabled pref is updated correctly when disabling brave/brave-ios
2 participants
@kylehickinson @Uni-verse