Fix #7844: Fix bug where backgroundView on stats is invisible #7845

Brandon-T · 2023-08-08T15:18:04Z

Summary of Changes

Fix background view not showing due to private-browsing condition returning early.

This pull request fixes #7844

Unit Tests are updated to cover new or changed functionality
User-facing strings use NSLocalizableString()
New or updated UI has been tested across:
- Light & dark mode
- Different size classes (iPhone, landscape, iPad)
- Different dynamic type sizes

Issues include necessary QA labels:
- QA/(Yes|No)
- bug / enhancement
Necessary security reviews have taken place.
Adequate unit test coverage exists to prevent regressions.
Adequate test plan exists for QA to validate (if applicable).
Issue and pull request is assigned to a milestone (should happen at merge time).

… times causing UI issues.

…visible (brave/brave-ios#7845) Fix bug where backgroundView on stats don't show or it shows multiple times causing UI issues.

Fix bug where backgroundView on stats don't show or it shows multiple…

778baac

… times causing UI issues.

Brandon-T added this to the 1.57 milestone Aug 8, 2023

Brandon-T self-assigned this Aug 8, 2023

Brandon-T requested a review from a team as a code owner August 8, 2023 15:18

iccub approved these changes Aug 8, 2023

View reviewed changes

iccub merged commit dbdd7d7 into development Aug 8, 2023

iccub deleted the bugfix/StatsProviderBackgroundView branch August 8, 2023 15:51