Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Private Stats background not showing on NTP #7844

Closed
Brandon-T opened this issue Aug 8, 2023 · 1 comment · Fixed by #7845
Closed

Private Stats background not showing on NTP #7844

Brandon-T opened this issue Aug 8, 2023 · 1 comment · Fixed by #7845
Assignees
@Brandon-T
Labels
bug QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.57

Comments

@Brandon-T
Copy link
Collaborator

Description:

  • Private Stats background no longer shows on NTP:

Steps to Reproduce

  1. View NTP in regular mode

Actual result:

image

Expected result:

image

Reproduces how often: [Easily reproduced, Intermittent Issue]

  • Easily reproduced

Brave Version:

  • 1.57.x
@Brandon-T Brandon-T added this to the 1.57 milestone Aug 8, 2023
@Brandon-T Brandon-T self-assigned this Aug 8, 2023
@Brandon-T Brandon-T mentioned this issue Aug 8, 2023
Merged
11 tasks
iccub pushed a commit that referenced this issue Aug 8, 2023
@Brandon-T
Fix #7844: Fix bug where backgroundView on stats is invisible (#7845)
dbdd7d7 
Fix bug where backgroundView on stats don't show or it shows multiple times causing UI issues.
@Uni-verse
Copy link
Contributor

Verified on iPhone X running iOS 16.5.1 using version 1.57 (23.8.18.20)

  • Ensured Private Stats background is shown on NTP on fresh profile.
  • Ensured user is able to hide/show the Stats on NTP in New Tab Page settings.
  • Ensured stats background is shown when upgrading from 1.56.x -> 1.57x.
Fresh Profile Existing Profile Private Tab
IMG_3473 IMG_3476 IMG_3475

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@Brandon-T
Fix brave/brave-ios#7844: Fix bug where backgroundView on stats is in…
0706296 
…visible (brave/brave-ios#7845)

Fix bug where backgroundView on stats don't show or it shows multiple times causing UI issues.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brandon-T Brandon-T

Labels
bug QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.57
Development

Successfully merging a pull request may close this issue.

Fix #7844: Fix bug where backgroundView on stats is invisible brave/brave-ios
2 participants
@Brandon-T @Uni-verse