Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7737: Crash at Browsing Mode Change while drag-drop action in Tab Tray #7778

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Jul 25, 2023

Adding check for active drag and drop while mode change

Summary of Changes

This pull request fixes #7737

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Launch Brave
  • Open at least 2 tabs
  • Tap on Tab switch button
  • Tap and hold on any tab, so you can drag the tab around
  • Now keep holding/dragging the tab and with another finger tap Private button > Observe Brave is crashing

Screenshots:

RPReplay_Final1690299361.MP4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel added this to the 1.57 milestone Jul 25, 2023
@soner-yuksel soner-yuksel requested a review from a team as a code owner July 25, 2023 15:38
@soner-yuksel soner-yuksel self-assigned this Jul 25, 2023
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@iccub iccub merged commit 61225da into development Jul 25, 2023
@iccub iccub deleted the fix/drop-crash-tablist branch July 25, 2023 16:15
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
…op action in Tab Tray (brave/brave-ios#7778)

Adding check for active drag and drop while mode change
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash at Browsing Mode Change while drag-drop action in Tab Tray
2 participants