Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Crash at Browsing Mode Change while drag-drop action in Tab Tray #7737

Closed
anthonypkeane opened this issue Jul 14, 2023 · 3 comments · Fixed by #7778
Closed

Crash at Browsing Mode Change while drag-drop action in Tab Tray #7737

anthonypkeane opened this issue Jul 14, 2023 · 3 comments · Fixed by #7778

Comments

@anthonypkeane
Copy link

Description:

https://appfigures.com/reviews/42132121512L44ERBxmkCeXQjERXN2I4BQ?lang=en

Hello, when being in the incognito overview and dragging one window with one finger, and then clicking the „private“ flag, the browser crashes

1.52

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@iccub iccub added this to the 1.56 milestone Jul 19, 2023
@iccub iccub added the QA/Yes label Jul 19, 2023
@iccub
Copy link
Contributor

iccub commented Jul 19, 2023

QA please give it a small test. we cant repro

@hffvld
Copy link
Collaborator

hffvld commented Jul 21, 2023

Hey @iccub I was able to reproduce it on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.5.1]
Brave build: 1.56 (23.7.19.18)
BraveCore: 1.56.6 (115.0.5790.90)

STEPS:

  1. Launch Brave
  2. Open at least 2 tabs
  3. Tap on Tab switch button
  4. Tap and hold on any tab, so you can drag the tab around
  5. Now keep holding/dragging the tab and with another finger tap Private button > Observe Brave is crashing

ACTUAL RESULTS:

  • Brave is crashing when user is holding a tab and tapping on Private button at the same time.

Crash.mov

@iccub iccub reopened this Jul 24, 2023
@iccub iccub removed this from the 1.56 milestone Jul 24, 2023
@soner-yuksel soner-yuksel changed the title User Review: App Crashes, reproducible Bug Crash at Browsing Mode Change while drag-drop action in Tab Tray Jul 25, 2023
@soner-yuksel soner-yuksel self-assigned this Jul 25, 2023
@soner-yuksel soner-yuksel added this to the 1.57 milestone Jul 25, 2023
iccub pushed a commit that referenced this issue Jul 25, 2023
…b Tray (#7778)

Adding check for active drag and drop while mode change
@hffvld
Copy link
Collaborator

hffvld commented Aug 18, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.6]
Brave build: 1.57 (23.8.16.21)
BraveCore: 1.57.47 (116.0.5845.96)

STEPS:
Followed the steps from #7737 (comment)

ACTUAL RESULTS:

  • Verified that Brave is not crashing when switching between Normal and Private tabs

Crash.fixed.mov

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
…op action in Tab Tray (brave/brave-ios#7778)

Adding check for active drag and drop while mode change
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.