Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #6260: Reverse order of URL bar context menu items when using bottom bar #7641

Merged
merged 3 commits into from
Jun 27, 2023
Merged

Fix #6260: Reverse order of URL bar context menu items when using bottom bar #7641

merged 3 commits into from
Jun 27, 2023

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Jun 26, 2023 •
edited
Loading

Changing Context Menu order and add additional menu section for better usability copy address

Summary of Changes

This pull request fixes #6260

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Test context menu order and spacing for both bottom and top toolbar order change

Screenshots:

1

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel self-assigned this Jun 26, 2023
@soner-yuksel soner-yuksel requested a review from a team as a code owner June 26, 2023 16:52
@soner-yuksel soner-yuksel added this to the 1.53 milestone Jun 27, 2023
@soner-yuksel soner-yuksel enabled auto-merge (squash) June 27, 2023 19:34
@soner-yuksel soner-yuksel merged commit 28b801b into development Jun 27, 2023
@soner-yuksel soner-yuksel deleted the fix/context-menu-order branch June 27, 2023 20:05
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@soner-yuksel
Fix brave/brave-ios#6260: Reverse order of URL bar context menu items…
a2c787c 
… when using bottom bar (brave/brave-ios#7641)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylehickinson kylehickinson kylehickinson approved these changes

Assignees

@soner-yuksel soner-yuksel

Labels
enhancement
Projects
None yet
Milestone
1.56
Development

Successfully merging this pull request may close these issues.

Reverse order of URL bar context menu items when using bottom bar
2 participants
@soner-yuksel @kylehickinson