Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Reverse order of URL bar context menu items when using bottom bar #6260

Closed
kylehickinson opened this issue Oct 26, 2022 · 1 comment · Fixed by #7641
Closed

Reverse order of URL bar context menu items when using bottom bar #6260

kylehickinson opened this issue Oct 26, 2022 · 1 comment · Fixed by #7641

Comments

@kylehickinson
Copy link
Collaborator

Description:

When you are using bottom bar we should reverse the order of the menu items when you long press and display the context menu. This will mean that the Paste & Go/Paste commands will be closer to your finger instead of on the opposite side

This will be more common in iOS 16 as they introduced a API to do this for you.

Ref #6235

@hffvld
Copy link
Collaborator

hffvld commented Jul 13, 2023

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 [iOS 16.5.1]
- iPad Air [iPadOS 16.5]
Brave build: 1.56 (23.7.13.16)
BraveCore: 1.56.5 (115.0.5790.75)

STEPS:

  1. Launch Brave
  2. Three-dot menu > Settings > TABS > Enable Bottom Bar
  3. Now go back and open any website
  4. Long tap on URL bar > Verify
  5. Go back to settings and enable Top Bar now
  6. Long tap on URL bar > Verify

ACTUAL RESULTS:

  • Verified the order of buttons on URL bar. From top to bottom:
    • Paste and Go, Paste and Copy Address when Top Bar is enabled;
    • Copy Address, Paste and Paste and Go when Bottom Bar is enabled;
  • Verified that functionality of the context menu is not broken

iPhone

Bottom Bar [Dark Mode] Bottom Bar [Light Mode] Top Bar [Dark Mode] Top Bar [Light Mode]
1 2 3 4

iPad

Top Bar [Dark Mode] Top Bar [Light Mode]
1 2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.