Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7396: Keep favicons monogram background color between launches. #7398

Merged
merged 1 commit into from
May 8, 2023

Conversation

iccub
Copy link
Contributor

@iccub iccub commented May 5, 2023

Summary of Changes

This pull request fixes #7396

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@iccub iccub requested a review from Brandon-T May 5, 2023 18:46
@iccub iccub requested a review from a team as a code owner May 5, 2023 18:46
@iccub iccub modified the milestones: 1.51, 1.52 May 8, 2023
@iccub iccub merged commit 7c4ca92 into development May 8, 2023
@iccub iccub deleted the bugfix/7396 branch May 8, 2023 13:59
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Monogram favicons change their color every app launch
2 participants