Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Monogram favicons change their color every app launch #7396

Closed
iccub opened this issue May 5, 2023 · 1 comment · Fixed by #7398
Closed

Monogram favicons change their color every app launch #7396

iccub opened this issue May 5, 2023 · 1 comment · Fixed by #7398

Comments

@iccub
Copy link
Contributor

iccub commented May 5, 2023

Description:

Steps to Reproduce

  1. Add example.com to favorites
  2. Notice its favicon background color
  3. Restart the app
  4. Notice the bg color again

Actual result:

It changes, bad for visual memory

Expected result:

Reproduces how often: [Easily reproduced, Intermittent Issue]

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight?
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@hffvld
Copy link
Collaborator

hffvld commented Jun 12, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.5]
Version: 1.52 (23.6.9.13)
BraveCore: 1.52.117 (114.0.5735.90)

STEPS:

  1. Launch Brave > NTP
  2. Go to www.example.com > Three-dot Menu > Add to Favorites
  3. Return to NTP > Verify background color for www.example.com
  4. Restart the app > Verify the background color for www.example.com once again

ACTUAL RESULTS:

  • Verified that the favicon for www.example.com has the same background color before and after the app restart.
Favicon.background.color.mov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants