Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7123: showing network logo on asset icon #7361

Merged
merged 5 commits into from
May 1, 2023

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Apr 28, 2023

Summary of Changes

  1. showing network logo on non-native asset icon
  2. added a border around network logo to match desktop
  3. add filecoin network logo for two filecoin (evm) networks

This pull request fixes #

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Check Portfolio/Token search/NFT tab
all non-native assets should display with a network logo
or if the network is not the official Ethereum network, but uses ETH as gas (e.x Ether on Aurora and Ether on Optimism)

Screenshots:

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-04-28.at.15.09.20.mp4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@nuo-xu nuo-xu added this to the 1.51 milestone Apr 28, 2023
@nuo-xu nuo-xu requested a review from StephenHeaps April 28, 2023 19:14
@nuo-xu nuo-xu self-assigned this Apr 28, 2023
@nuo-xu nuo-xu requested a review from a team as a code owner April 28, 2023 19:14
@nuo-xu nuo-xu requested a review from StephenHeaps May 1, 2023 18:12
@nuo-xu nuo-xu force-pushed the wallet/network-icon-on-assets branch from 3ed617a to fcaf57b Compare May 1, 2023 19:48
@nuo-xu nuo-xu merged commit 8293f41 into development May 1, 2023
@nuo-xu nuo-xu deleted the wallet/network-icon-on-assets branch May 1, 2023 20:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants