Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Show network logo over asset icon instead of coin logo #7123

Closed
StephenHeaps opened this issue Mar 21, 2023 · 1 comment
Closed

Show network logo over asset icon instead of coin logo #7123

StephenHeaps opened this issue Mar 21, 2023 · 1 comment
Assignees
@nuo-xu
Labels
Epic: Brave Wallet priority/P4 Planned work. We expect to get to it "soon". QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.51

Comments

@StephenHeaps
Copy link
Contributor

Description:

iOS version of brave/brave-browser#29166

We should update to show the network logo in the corner of asset icons instead of the coin logo.
@HEagle18 HEagle18 added the priority/P4 Planned work. We expect to get to it "soon". label Mar 31, 2023
@nuo-xu nuo-xu self-assigned this Apr 26, 2023
@nuo-xu nuo-xu added the QA/Yes label Apr 26, 2023
@nuo-xu nuo-xu closed this as completed in 8293f41 May 1, 2023
@iccub iccub added this to the 1.51 milestone May 8, 2023
@hffvld
Copy link
Collaborator

hffvld commented May 8, 2023

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: iPhone 14 [iOS 16.4.1] and iPad Air [iPadOS 16.4.1]
Version: 1.51 (23.5.8.16) 
BraveCore: 1.51.110 (113.0.5672.77)

STEPS:

  1. Launch Brave > Three dot Menu > Wallet
  2. Enter Wallet password > Unlock
  3. Tap All Networks > Change it to Solana > Verify
  4. Repeat Step 3 and change it to a few different Networks > Verify

ACTUAL RESULTS:

  • Verified that the Network logo is shown in the corner of asset icons instead of the coin logo
Wallet_Network.icon.mov

@Uni-verse Uni-verse mentioned this issue Jul 18, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@nuo-xu
Fix brave/brave-ios#7123: showing network logo on asset icon (brave/b…
ec256d8 
…rave-ios#7361)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@nuo-xu nuo-xu

Labels
Epic: Brave Wallet priority/P4 Planned work. We expect to get to it "soon". QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.51
Development

No branches or pull requests
6 participants
@nuo-xu @StephenHeaps @iccub @HEagle18 @Uni-verse @hffvld