-
Notifications
You must be signed in to change notification settings - Fork 442
Conversation
4f16586
to
b2281fb
Compare
b2281fb
to
eb5ed03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may want to cache the token details so it doesn't reload when popping the asset detail off navigation stack which causes us to lose scroll position (same logic would apply when switching to this activity tab after previously loading the market data):
cache.market.data.mp4
Update: Resolved by checking if marketStore.coins.isEmpty
before showing loading state.
b10b4ab
to
b27af08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few code comments, functionality wise it's working great 👍.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work 🎉
Signed-off-by: Nuo Xu <[email protected]>
Signed-off-by: Nuo Xu <[email protected]>
Signed-off-by: Nuo Xu <[email protected]>
Signed-off-by: Nuo Xu <[email protected]>
75465de
to
e82f244
Compare
Summary of Changes
We are introducing a tab
Market
which will display the top 250 tokens in the market from CoinGeckoThis pull request fixes #7202
Submitter Checklist:
NSLocalizableString()
Test Plan:
Buy
button available inside token detail screen, when this token's symbol can be found in all available buy tokens with all supported providers in CURRENT SELECTED network (For example, if your current selected network is Eth mainnet, then Eth token detail screen will have theBuy
button, but not Solana token)Screenshots:
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement