Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Wallet: Market Tab #7202

Closed
nuo-xu opened this issue Apr 4, 2023 · 2 comments · Fixed by #7298
Closed

Wallet: Market Tab #7202

nuo-xu opened this issue Apr 4, 2023 · 2 comments · Fixed by #7298

Comments

@nuo-xu
Copy link
Contributor

nuo-xu commented Apr 4, 2023

Description:
Integrate market tab.
Figma: https://www.figma.com/file/muVcmcu4RFNu0LkXe9VRDl/Wallet-Panel?node-id=1406-218312&t=EssV5dFsjKICuh2p-0
Each Token row should show:
Token name, token symbol, token image, 24h price change %, price of asset
Tapping an asset will open to Asset Details

TBD:

  1. search
  2. filter
  3. sorting
  4. rank

Desktop screenshot for reference
Screenshot 2023-04-04 at 12 43 22 PM

@nuo-xu nuo-xu self-assigned this Apr 4, 2023
@diracdeltas
Copy link
Member

may need a quick security review

@nuo-xu nuo-xu added the QA/Yes label Apr 11, 2023
nuo-xu added a commit that referenced this issue Apr 25, 2023
@iccub iccub added this to the 1.51 milestone Apr 25, 2023
@srirambv
Copy link
Contributor

srirambv commented May 5, 2023

Verification passed on the following devices running 1.51 (23.4.28.18)

  • Verified steps from #7298
  • Verified wallet now shows a Market tab
  • Verified switching to Market tab shows loading state populating the token list
  • Verified token's name, symbol, logo, current price and price delta is shown
  • Verified clicking on any token navigates to the token detail screen
  • Verified inside token detail screen there is no information related to the active/selected network
  • Verified inside token detail screen, there is no account balances or transactions listed
  • Verified inside token detail screen, price, price delta and price history are being shown
  • Verified inside token detail screen, token rank, 24h volume and market cap information are being shown
  • Verified tokens pertaining to the selected network show Buy button in token details screen but tokens of different network doesn't show the Buy button in token details screen
iPhone 7+ (iOS 15.7.3) iPad Pro (16.4 Beta 4)
7202-iPhone.7+.MP4
7202-iPad.Pro.MP4

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants