Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7103: Shields show Session Restore - Reader Mode Internal URL #7264

Merged
merged 2 commits into from
Apr 19, 2023

Conversation

soner-yuksel
Copy link
Contributor

Summary of Changes

Adding Internal URL display for Shields Screen

This pull request fixes #7103

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Test 1:

Load a page
Quit browser and relaunch
Open shields while the page is loading

Test 2:

Load a page
Activate Reader mode
Open shields

Screenshots:

1 1 1 1 2 3 1

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@soner-yuksel soner-yuksel requested a review from a team as a code owner April 17, 2023 14:38
@soner-yuksel soner-yuksel self-assigned this Apr 17, 2023
@iccub iccub requested a review from Brandon-T April 17, 2023 15:10
@soner-yuksel soner-yuksel requested a review from Brandon-T April 17, 2023 17:09
@soner-yuksel soner-yuksel added this to the 1.51 milestone Apr 19, 2023
@soner-yuksel soner-yuksel merged commit 9c95048 into development Apr 19, 2023
@soner-yuksel soner-yuksel deleted the fix/internal-shields-display branch April 19, 2023 14:15
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shields show Session Restore - Reader Mode Internal URL
2 participants