Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Shields show Session Restore - Reader Mode Internal URL #7103

Closed
srirambv opened this issue Mar 16, 2023 · 2 comments · Fixed by #7264
Closed

Shields show Session Restore - Reader Mode Internal URL #7103

srirambv opened this issue Mar 16, 2023 · 2 comments · Fixed by #7264

Comments

@srirambv
Copy link
Contributor

srirambv commented Mar 16, 2023

Description:

Shields show INTERNAL://LOCAL/SESSIONRESTORE?URL= whilst the page is loading. In addition when Reader Mode is activated Shields show INTERNAL://LOCAL/READER-MODE?URL= if reader mode is activated.

Steps to Reproduce

Test 1:

  1. Load a page
  2. Quit browser and relaunch
  3. Open shields while the page is loading

Test 2:

  1. Load a page
  2. Activate Reader mode
  3. Open shields

Actual result:

test1 1

Expected result:

Should show original URL

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easy

Brave Version:

1.49(23.3.15.7)

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight?
  • Can you reproduce this issue with the current build from AppStore?

Device details:

All

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

cc: @kylehickinson @iccub @Brandon-T

@soner-yuksel soner-yuksel self-assigned this Apr 17, 2023
@soner-yuksel soner-yuksel added this to the 1.51 milestone Apr 17, 2023
@soner-yuksel soner-yuksel changed the title Shields show INTERNAL://LOCAL/SESSIONRESTORE?URL= whilst the page is loading Shields show Session Restore - Reader Mode Internal URL Apr 17, 2023
@soner-yuksel
Copy link
Contributor

This problem also happens with Reader-Mode pages. The ticket is updated accordingly with test plan and ss's added.

@hffvld
Copy link
Collaborator

hffvld commented May 8, 2023

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: iPhone 14 [iOS 16.4.1] and iPad Air [iPadOS 16.4.1]
Version: 1.51 (23.5.8.16) 
BraveCore: 1.51.110 (113.0.5672.77)

STEPS:

Test 1:

  1. Load a page
  2. Quit browser and relaunch
  3. Open shields while the page is loading

Test 2:

  1. Load a page
  2. Activate Reader mode
  3. Open shields

ACTUAL RESULTS:

  • Verified actual URL is shown in Shields when restarting Brave
  • Verified actual URL is shown in Shields when Reader Mode is enabled
Shields_Reopen.page.mov
Shields_Reader.Mode.mov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.