Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #6171: Don't shift switches on shields view when text gets too long #6984

Merged
merged 1 commit into from
Feb 22, 2023
Merged

Fix #6171: Don't shift switches on shields view when text gets too long #6984

merged 1 commit into from
Feb 22, 2023

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Feb 21, 2023 •
edited by iccub
Loading

Summary of Changes

This pull request fixes #6171

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Screenshots:

Simulator Screenshot - iPhone 14 Pro - 2023-02-21 at 16 30 44

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson requested a review from a team as a code owner February 21, 2023 21:33
@iccub iccub added this to the 1.49 milestone Feb 22, 2023
@kylehickinson kylehickinson merged commit 1b36bb3 into development Feb 22, 2023
@kylehickinson kylehickinson deleted the shields-toggle-cutoff branch February 22, 2023 15:48
@srirambv srirambv mentioned this pull request Mar 16, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
@kylehickinson
Fix brave/brave-ios#6171: Don't shift switches on shields view when t…
08051ea 
…ext gets too long (brave/brave-ios#6984)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.49
Development

Successfully merging this pull request may close these issues.

Shields panel toggle is off in German locale
2 participants
@kylehickinson @iccub