Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Shields panel toggle is off in German locale #6171

Closed
iccub opened this issue Oct 13, 2022 · 2 comments · Fixed by #6984
Closed

Shields panel toggle is off in German locale #6171

iccub opened this issue Oct 13, 2022 · 2 comments · Fixed by #6984
Assignees
@kylehickinson
Labels
bug Epic: UI/UX QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.49

Comments

@iccub
Copy link
Contributor

iccub commented Oct 13, 2022

Zrzut ekranu 2022-10-13 o 20 47 03
@iccub iccub changed the title Shields panel toggle is off in Germany locale Shields panel toggle is off in German locale Oct 13, 2022
@iccub
Copy link
Contributor Author

iccub commented Oct 13, 2022

Maybe this can be a bigger ticket, to make this panel support dynamic fonts

@kylehickinson kylehickinson self-assigned this Feb 21, 2023
kylehickinson added a commit that referenced this issue Feb 21, 2023
@kylehickinson
Fix #6171: Don't shift switches on shields view when text gets too long
ca81cdd
@kylehickinson kylehickinson mentioned this issue Feb 21, 2023
Merged
11 tasks
@kylehickinson kylehickinson added this to the 1.49 milestone Feb 21, 2023
kylehickinson added a commit that referenced this issue Feb 22, 2023
@kylehickinson
Fix #6171: Don't shift switches on shields view when text gets too lo…
1b36bb3 
…ng (#6984)
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.49 (23.3.15.17)

  • Verified steps from #6984
  • Verified text is line wrapped and doesn't push the button off alignment
iPhone 7+ (iOS 15.7.3) iPhone XR (iOS 16.3.1) iPad Pro (16.4 Beta 2)

@Uni-verse Uni-verse mentioned this issue Apr 13, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@kylehickinson
Fix brave/brave-ios#6171: Don't shift switches on shields view when t…
08051ea 
…ext gets too long (brave/brave-ios#6984)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: UI/UX QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.49
Development

Successfully merging a pull request may close this issue.

Fix #6171: Don't shift switches on shields view when text gets too long brave/brave-ios
3 participants
@kylehickinson @iccub @srirambv