This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #5636: Invalidate NTP layout when sections change to fix News layout #6875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On first launches default favourites are added async which cause FRCs to fire after NTP is already laid out, which trigger
sectionDidChange
. When this happens we were reloading the changed sections without animation but this would sometimes cause layout issues with sections not reloaded like Brave News.Summary of Changes
This pull request fixes #5636
Submitter Checklist:
NSLocalizableString()
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement