Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #5636: Invalidate NTP layout when sections change to fix News layout #6875

Merged
merged 1 commit into from
Feb 3, 2023

Conversation

kylehickinson
Copy link
Collaborator

On first launches default favourites are added async which cause FRCs to fire after NTP is already laid out, which trigger sectionDidChange. When this happens we were reloading the changed sections without animation but this would sometimes cause layout issues with sections not reloaded like Brave News.

Summary of Changes

This pull request fixes #5636

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

On first launches default favourites are added async which cause FRCs to fire after NTP is already laid out, which trigger `sectionDidChange`. When this happens we were reloading the changed sections without animation but this would sometimes cause layout issues with sections not reloaded like Brave News.
@kylehickinson kylehickinson requested a review from a team February 3, 2023 17:20
@kylehickinson kylehickinson added this to the 1.48 milestone Feb 3, 2023
@kylehickinson kylehickinson merged commit 50b309a into development Feb 3, 2023
@kylehickinson kylehickinson deleted the ntp-section-change-layout-invalidation branch February 3, 2023 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Peeking card on first launch missing text/animations until refresh [iOS 15]
2 participants