Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Peeking card on first launch missing text/animations until refresh [iOS 15] #5636

Closed
Uni-verse opened this issue Jun 30, 2022 · 1 comment · Fixed by #6875
Closed

Peeking card on first launch missing text/animations until refresh [iOS 15] #5636

Uni-verse opened this issue Jun 30, 2022 · 1 comment · Fixed by #6875
Assignees
@kylehickinson
Labels
bug Epic: Brave News priority/P3 The next thing for us to work on. QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes
Milestone
1.48

Comments

@Uni-verse
Copy link
Contributor

Description:

First part of the content missing on the peeking card on first launch until user pulls to refresh or opens new tab. Only happening on iOS 15.x it seems.

Steps to Reproduce

  1. Clean install
  2. Observe content on brave news card

Actual result:

RPReplay_Final1656617672.MP4

Expected result:
0

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily

Brave Version:
1.40.x
1.39.1

Device details:
iOS 15.x, iPadOS 15.x
@kylehickinson kylehickinson mentioned this issue Jan 18, 2023
Closed
@kylehickinson kylehickinson self-assigned this Feb 3, 2023
kylehickinson added a commit that referenced this issue Feb 3, 2023
@kylehickinson
Fix #5636: Invalidate NTP layout when sections change to fix News layout
0f65bd4 
On first launches default favourites are added async which cause FRCs to fire after NTP is already laid out, which trigger `sectionDidChange`. When this happens we were reloading the changed sections without animation but this would sometimes cause layout issues with sections not reloaded like Brave News.
@kylehickinson kylehickinson mentioned this issue Feb 3, 2023
Merged
11 tasks
kylehickinson added a commit that referenced this issue Feb 3, 2023
@kylehickinson
Fix #5636: Invalidate NTP layout when sections change to fix News lay…
50b309a 
…out (#6875)

On first launches default favourites are added async which cause FRCs to fire after NTP is already laid out, which trigger `sectionDidChange`. When this happens we were reloading the changed sections without animation but this would sometimes cause layout issues with sections not reloaded like Brave News.
@kylehickinson kylehickinson added this to the 1.48 milestone Feb 3, 2023
@Uni-verse
Copy link
Contributor Author

Uni-verse commented Feb 13, 2023 •
edited
Loading

Verified on the following devices using version 1.48 (23.2.10.14)

iPhone 12, iOS 16.2
iPhone XR, iOS 15.5
iPad (9th Gen), iPadOS 15.6.1

  • Ensured that content is not missing from the peeking card/news onboarding card on NTP

Encountered: #6938

iPhoneiPad
RPReplay_Final1676321530.MP4
RPReplay_Final1676321671.MP4

@Uni-verse Uni-verse mentioned this issue Feb 13, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: Brave News priority/P3 The next thing for us to work on. QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes
Projects
None yet
Milestone
1.48
Development

Successfully merging a pull request may close this issue.

Fix #5636: Invalidate NTP layout when sections change to fix News layout brave/brave-ios
2 participants
@kylehickinson @Uni-verse