Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

No Bug: Fix incorrect url bar focusing behaviour when opening blank tabs #6258

Merged
merged 1 commit into from
Oct 26, 2022

Conversation

kylehickinson
Copy link
Collaborator

As of #6150 merging, the openBlankNewTab was fixed to actually focus the URL bar when passing in true for the attemptLocationFieldFocus argument. However it turns out that we call this method with true all throughout the app even though we don't want the URL bar to focus in most of these scenarios.

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  • Verify opening via search widget indeed focuses the URL bar
  • Verify opening blank new tabs in all other scenarios do not focus the URL bar

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

As of #6150 merging, the `openBlankNewTab` was fixed to actually focus the URL bar when passing in `true` for the `attemptLocationFieldFocus` argument. However it turns out that we call this method with `true` all throughout the app even though we don't want the URL bar to focus in most of these scenarios.
@kylehickinson kylehickinson requested a review from a team October 26, 2022 18:45
@kylehickinson kylehickinson added this to the 1.45 milestone Oct 26, 2022
@kylehickinson kylehickinson merged commit beb9eee into development Oct 26, 2022
@kylehickinson kylehickinson deleted the field-focus-bug branch October 26, 2022 19:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants