This repository has been archived by the owner on May 10, 2024. It is now read-only.
No Bug: Fix incorrect url bar focusing behaviour when opening blank tabs #6258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of #6150 merging, the
openBlankNewTab
was fixed to actually focus the URL bar when passing intrue
for theattemptLocationFieldFocus
argument. However it turns out that we call this method withtrue
all throughout the app even though we don't want the URL bar to focus in most of these scenarios.Submitter Checklist:
NSLocalizableString()
Test Plan:
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement