This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #5920: Add lock screen widgets for favorites & shortcuts #6150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylehickinson
commented
Oct 11, 2022
kylehickinson
force-pushed
the
16-widgets
branch
from
29cee1c
to
3435807
Compare
iccub
approved these changes
Oct 12, 2022
kylehickinson
force-pushed
the
16-widgets
branch
3 times, most recently
from
c1f331b
to
922fd95
Compare
kylehickinson
force-pushed
the
16-widgets
branch
from
922fd95
to
3b93497
Compare
kylehickinson
added a commit
that referenced
this pull request
Oct 26, 2022
As of #6150 merging, the `openBlankNewTab` was fixed to actually focus the URL bar when passing in `true` for the `attemptLocationFieldFocus` argument. However it turns out that we call this method with `true` all throughout the app even though we don't want the URL bar to focus in most of these scenarios.
kylehickinson
added a commit
that referenced
this pull request
Oct 26, 2022
As of #6150 merging, the `openBlankNewTab` was fixed to actually focus the URL bar when passing in `true` for the `attemptLocationFieldFocus` argument. However it turns out that we call this method with `true` all throughout the app even though we don't want the URL bar to focus in most of these scenarios.
11 tasks
kylehickinson
added a commit
that referenced
this pull request
Oct 26, 2022
…abs (#6258) As of #6150 merging, the `openBlankNewTab` was fixed to actually focus the URL bar when passing in `true` for the `attemptLocationFieldFocus` argument. However it turns out that we call this method with `true` all throughout the app even though we don't want the URL bar to focus in most of these scenarios.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also adds shortcut options for Search & Brave Wallet on the regular home screen shortcuts widget
Summary of Changes
This pull request fixes #5920
Submitter Checklist:
NSLocalizableString()Screenshots:
Reviewer Checklist:
QA/(Yes|No)bug/enhancement