-
Notifications
You must be signed in to change notification settings - Fork 442
Added JS event listener for tab web-state. #5181
Conversation
12e054d
to
0de8e2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me privacy-wise, though i made a few small suggestions for cleanup and consistency
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, i ran this code for a bit and seems to work for all cases and websites
@Brandon-T i was not done reviewing this yet - in the future please wait til sec review is closed |
Ahh sorry. I saw the |
@Brandon-T thanks, no need in this case since my comments are mostly questions. but for future reference sgtm = |
Security Review
Summary of Changes
This pull request fixes #5180
Submitter Checklist:
NSLocalizableString()
Reviewer Checklist:
QA/(Yes|No)
bug
/enhancement