Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[Bug] - Websites with Dynamic Loading not storing screenshots & state properly #5180

Closed
Brandon-T opened this issue Mar 30, 2022 · 1 comment · Fixed by #5181
Closed

[Bug] - Websites with Dynamic Loading not storing screenshots & state properly #5180

Brandon-T opened this issue Mar 30, 2022 · 1 comment · Fixed by #5181

Comments

@Brandon-T
Copy link
Collaborator

Description:

  • Some websites like Youtube & Twitter uses dynamic loading. They modify the history stack in the browser, so we don't get a callback like didFinish in WKWebView. This can cause problems where we attempt to save screenshots for TabTray or saving History. The history part was solved in an earlier PR, so this PR will solidify that and solve the screenshots part.

Steps to Reproduce

  1. See: Youtube URL/state not remembered after closing browser #5075

Actual result:

  • Youtube or Twitter not session restoring properly.
  • Screenshots in TabTray sometimes blank.

Expected result:

  • Should restore correct page
  • Should show correct tabs screenshots in TabTray.

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easily reproduced

Brave Version:
1.35

@Uni-verse
Copy link
Contributor

Uni-verse commented Apr 29, 2022

Verification completed using 1.38 (22.4.28.18)

Devices:
iPhone 12 Pro | iOS 15.4
iPhone X | iOS 14.4.2
iPad | IOS 15.2.1

Test Case #1 Using STR #5075 (comment)

  • Confirmed that session is being restored correctly on YT and Twitter

Test Case #2 Tab tray session screenshots

  1. Open many videos on youtube in new tabs
  2. Close the app using the app switcher
  3. Relaunch brave
  4. Open tab tray
  • Ensured that the correct urls are being restored in the screenshots when tab tray is open

Note: The body of the screenshots in the tab tray aren't showing intermittently. This is more noticable on iPad

iPad iPhone
IMG_0270 IMG_2672

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants