Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #3673 - Implements CarPlay + Refactor Playlist #3887

Merged
merged 7 commits into from
Aug 27, 2021

Conversation

Brandon-T
Copy link
Collaborator

@Brandon-T Brandon-T commented Jul 6, 2021

Summary of Changes

This pull request fixes #3673

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@Brandon-T Brandon-T added this to the 1.29 milestone Jul 6, 2021
@Brandon-T Brandon-T force-pushed the feature/Playlist-Carplay branch 2 times, most recently from 1392f5a to 4f35dd8 Compare July 9, 2021 15:29
@iccub iccub modified the milestones: 1.29, 1.30 Jul 12, 2021
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left few nitpick comments, will run this branch later

Besides that I think there are 2 areas worth looking into:

  • See if we can remove tight coupling with BVC/App Delegate. In the future we will move to using SceneDelegates, which means we should think what code will be shared and what will be different for each opened window/scene. You can see if we can utilize delegates or passing bvc in constructor if we ever need access to it
  • I had a feeling that some of code between regular player and car play player can be shared. You can see if it makes sense in any place. Of course it may not make sense to share code even if it looks similar. I'm not pro DRY in every case, just something to think about.

@iccub iccub modified the milestones: 1.30, 1.31 Aug 2, 2021
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feedback review looks good to me, I will run this branch and leave functional review next week

@Brandon-T Brandon-T force-pushed the feature/Playlist-Carplay branch 2 times, most recently from 76d8ae5 to 6a69081 Compare August 13, 2021 15:34
@kylehickinson
Copy link
Collaborator

kylehickinson commented Aug 13, 2021

FYI after we merge this we must update provisioning profiles to include the CarPlay entitlement otherwise the app will fail to sign in Release builds. Apple has made us entitlements that include both Default Web Browser and CarPlay.

@Brandon-T Brandon-T force-pushed the feature/Playlist-Carplay branch 4 times, most recently from 55341ae to d44c06f Compare August 25, 2021 13:44
@iccub iccub modified the milestones: 1.31, 1.32 Aug 25, 2021
@Brandon-T Brandon-T requested a review from iccub August 26, 2021 14:57
@Brandon-T Brandon-T merged commit c576b52 into development Aug 27, 2021
@Brandon-T Brandon-T deleted the feature/Playlist-Carplay branch August 27, 2021 13:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Carplay
3 participants