Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add support for Carplay #3673

Closed
anthonypkeane opened this issue May 11, 2021 · 1 comment · Fixed by #3887
Closed

Add support for Carplay #3673

anthonypkeane opened this issue May 11, 2021 · 1 comment · Fixed by #3887

Comments

@anthonypkeane
Copy link

Description:

In Playlist, please add support for Carplay

@iccub iccub added this to the 1.30 milestone Jul 12, 2021
@anthonypkeane anthonypkeane modified the milestones: 1.30, 1.31 Jul 15, 2021
@iccub iccub modified the milestones: 1.31, 1.32 Aug 25, 2021
Brandon-T added a commit that referenced this issue Aug 27, 2021
* Implement Carplay!

* Addressing some feedback.

* Localized strings.

* Fixed seeking to last played time.

* Fix conflict with background playback and playlist.

* Adding comments to the code.

* Fixing playback for carplay! Working almost perfectly.
@srirambv
Copy link
Contributor

srirambv commented Oct 21, 2021

Verification passed on iPhone 7+ (iOS 14.8) and iPhone XR (iOS 15.0.1) running 1.32.1(21.10.20.18)
  • Verified Brave shows up as an app when the device is connected to CarPlay using USB cable
    image
  • Verified clicking on Brave opens up the Playlist by default
  • Verified when if playlist is empty then shows message about no items available
  • Verified when playlist has items lists the playlist items in the same order
image image
  • Verified settings shows option for restarting playlist item when selected which is disabled by default
  • Verified enabling the setting causes the track to start from beginning when selected from the playlist or if the same track is playing
image image image
  • Verified when a track is playing it shows the playing indicator on the track and on the top right corner
    image

  • Verified clicking on the playing indicator on the top right opens up the now playing track
    image

  • Verified when a playlist item is being played and the device is removed the current playing track stops on the device as well

  • Verified after connecting to CarPlay, playing a track on playlist and disconnect the device and reconnecting automatically starts the playback from where it left off

  • Encountered Playback fails when device is connected back to CarPlay  #4383 when trying to playback after reconnecting device

  • Verified when an item is still downloading or not has been removed from offline playback shows a cloud icon next to the track
    image

  • Verified playlist pauses when there is an incoming call. Encountered Playback pauses when a phone call is received #4362

  • Verified while playing from playlist via CarPlay, using voice command for Siri pauses the carplay

  • Verified while playing from playlist via CarPlay, notifications from Apps can be read out loud

  • Verified while playing from playlist via CarPlay, able to use browser for other functions

  • Verified while playing from playlist via CarPlay, can use maps for navigation and navigation commands can be heard over the track that is currently playing

  • Verified when a track finishes and the next one starts, automatically view changes from playlist to now playing

  • Verified tracks follow the track speed set in playlist

Verification PASSED on iPhone 12 running iOS 15.0.2 using 1.32.1 (21.10.28.15)
  • ensured that Brave appears as an available application when connnected to CarPlay via Bluetooth
  • ensured that tapping on the Brave icon opens the Playlist by default
  • ensured that a No Items Available is displayed for on installs or if someone doesn't have anything added within the Playlist
CarPlay Home Default/Clean Install Playlist Items Added
IMG_9662 IMG_9664 IMG_9670
  • ensured that media is still playing when clicking on Home via CarPlay
  • ensured that the current media that's being played is displayed in the Home screen via CarPlay
  • ensured that the controls work as expected via the Home screen on CarPlay (Back/Forwards & Pause)
  • ensured that clicking on the media panel under the Home screen via CarPlay opens the Brave application
CarPlay Home Screen Clicking on Media Panel via CarPlay
IMG_9674 IMG_9680
  • ensured that receiving notifications from other applications doesn't interrupt the current media being played
  • ensured that the notification is being displayed without any issue in various areas (Brave/CarPlay Home)
  • ensured that tapping on the notification opens the corresponding application within CarPlay without issues
Notification via Brave Playlist Notification via Brave Playlist
IMG_9684 IMG_9682
  • ensured that both the Brave (Browser) and Brave via Carplay display the same Playlist order
  • ensured that changing the order of the Playlist via browser correctly updates Carplay without any issues
  • ensured that changing the order while media is being played correctly updates Carplay and doesn't cause issues
Playlist Order Browser Playlist Order CarPlay
IMG_9686 IMG_9685
  • ensured that Restart Playback under Settings is disabled by default
  • ensured that tapping on the circle via Tap to enable playback restarting enables the feature
  • ensured there's a orange Check indicating Restarting Playback has been enabled
  • ensured that tapping on < Back via Playback Options goes back to the main settings page
  • ensured that switching between Playlist & Settings works without any issues
Settings Playback Restart Disabled Playback Restart Enabled
IMG_9692 IMG_9688 IMG_9690
  • ensured that the play indicator is visible under the Playlist view when media is being played

IMG_9694

  • ensured that tapping on the Play icon at the top right of the screen opens the media that's currently being played

IMG_9696

  • ensured that disabling Bluetooth/WiFi and disconnecting from CarPlay stops the currently playing media without issues
  • ensured that the cloud icon is displayed when media is still being downloaded via the browser
  • ensured that the cloud icon re-appears when media that has already been downloaded is removed via the browser
Re-downloading removed media (CarPlay) Re-downloading removed media (Browser)
IMG_9698 IMG_9697
  • ensured that you can still use Brave for other functions while connected to CarPlay and media is being played
  • ensured that you can also control media currently being played within the browser/iPhone notification area
  • ensured that when media is finished playing, the next item is being played automaticallt
  • ensured that map navigation is working while media is being played via Brave

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.