This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #3838: Improve menu accessibility #3845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
approved these changes
Jun 24, 2021
| @@ -198,7 +203,7 @@ extension MenuViewController: PanModalPresentable { | |||
| return _scrollViewChild(in: topVC.view) | |||
| } | |||
| var longFormHeight: PanModalHeight { | |||
| .maxHeight | |||
| .maxHeightWithTopInset(32) | |||
There was a problem hiding this comment.
Is this for this ticket or the last-bookmark-hidden one?
There was a problem hiding this comment.
That is for this ticket:
Increases the top inset so there is always space to tap to dismiss the menu
It helps VoiceOver users or users with motor function disabilities to dismiss by tapping the background instead of being forced to dismiss by gesture
soner-yuksel
approved these changes
Jun 24, 2021
- Adds support for accessibility escape while VoiceOver is active - Increases the top inset so there is always space to tap to dismiss the menu
kylehickinson
force-pushed
the
menu-accessibility
branch
from
fd92dcd
to
ef37f57
Compare
kylehickinson
added a commit
that referenced
this pull request
Jun 24, 2021
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #3838
Submitter Checklist:
NSLocalizableString()Test Plan:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement