Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Very difficult to dismiss the new menu while VoiceOver is active #3838

Closed
kylehickinson opened this issue Jun 23, 2021 · 1 comment · Fixed by #3845
Closed

Very difficult to dismiss the new menu while VoiceOver is active #3838

kylehickinson opened this issue Jun 23, 2021 · 1 comment · Fixed by #3845

Comments

@kylehickinson
Copy link
Collaborator

Description:

While VoiceOver is active it is very difficult/near impossible to dismiss the new menu once its been displayed.

We should remedy this in two ways:

  • Support the scrub gesture (2-finger z shape swipe -- "Dismiss an alert or return to the previous screen") which will trigger menu dismissal
  • Increase the space from the top of the screen to add the ability to tap the background to dismiss

Steps to Reproduce

  1. Turn on VoiceOver
  2. Open the new menu (•••)

Actual result: You can't dismiss the new menu with VoiceOver gestures

Expected result: You should be able to dismiss the new menu without selecting Playlist or an action that dismisses it for you such as page actions

Reproduces how often: Always while VoiceOver is active

Brave Version: 1.26+

@kylehickinson kylehickinson added this to the 1.28 milestone Jun 23, 2021
@kylehickinson kylehickinson self-assigned this Jun 23, 2021
kylehickinson added a commit that referenced this issue Jun 24, 2021
- Adds support for accessibility escape while VoiceOver is active
- Increases the top inset so there is always space to tap to dismiss the menu
kylehickinson added a commit that referenced this issue Jun 24, 2021
- Adds support for accessibility escape while VoiceOver is active
- Increases the top inset so there is always space to tap to dismiss the menu
kylehickinson added a commit that referenced this issue Jun 24, 2021
- Adds support for accessibility escape while VoiceOver is active
- Increases the top inset so there is always space to tap to dismiss the menu
kylehickinson added a commit that referenced this issue Jun 24, 2021
- Adds support for accessibility escape while VoiceOver is active
- Increases the top inset so there is always space to tap to dismiss the menu
kylehickinson added a commit that referenced this issue Jun 25, 2021
PanModal uses `topOffset` to determine the height of the presenting controller rather than the `longFormHeight`, so adjusting where I add that 32pt's for accessibility to fix the bug caused by adding that 32pt's in the wrong location.
iccub pushed a commit that referenced this issue Jun 25, 2021
PanModal uses `topOffset` to determine the height of the presenting controller rather than the `longFormHeight`, so adjusting where I add that 32pt's for accessibility to fix the bug caused by adding that 32pt's in the wrong location.
iccub pushed a commit that referenced this issue Jun 25, 2021
PanModal uses `topOffset` to determine the height of the presenting controller rather than the `longFormHeight`, so adjusting where I add that 32pt's for accessibility to fix the bug caused by adding that 32pt's in the wrong location.
@srirambv
Copy link
Contributor

srirambv commented Jul 9, 2021

Verification passed on iPhone XR with iOS 13.5 running 1.28(21.7.8.16)


Verification passed on iPhone 7+ with iOS 14.5.1 running 1.28(21.7.8.16)


Verification passed on iPad Pro with iOS 14.6 running 1.28(21.7.8.16)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.