Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #3855: Small Refactor of Playlist Helper #3781

Merged
merged 2 commits into from
Jul 7, 2021

Conversation

Brandon-T
Copy link
Collaborator

@Brandon-T Brandon-T commented Jun 14, 2021

Summary of Changes

  • Refactor some of the code to make it cleaner and easier to read, understand, and maintain
  • Refactor the AVURLAsset to check the playable status before even calling any playable loading functions
  • Removed logging of WKScriptMessage on a delayed Main-Thread. I do NOT know if this will fix a possible crash because I can never reproduce it, but this one is a guess at a possible solution (though, the previous code did access it only on main-thread, this is just better anyway).

This pull request fixes #3855

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Test on a very slow network using the Link Conditioner
  • Refresh the page, attempt to scroll immediately and keep scrolling for up to 10 seconds after the page fully loads and the playlist bar shows.
  • If scrolling is smooth as the previous build, we're good.

Screenshots:

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@Brandon-T Brandon-T requested a review from a team June 14, 2021 19:51
@iccub iccub added this to the 1.28 milestone Jun 15, 2021
@iccub iccub changed the title [No Bug] - Small Refactor of Playlist Helper Fix #3855: Small Refactor of Playlist Helper Jun 28, 2021
@iccub iccub modified the milestones: 1.28, 1.29 Jun 29, 2021
Refactoring code to make it clearer.
Removing access of WKScriptMessage for logging (not sure if this will fix a possible script crash in WebKit).
@Brandon-T Brandon-T merged commit 47e2912 into development Jul 7, 2021
@Brandon-T Brandon-T deleted the playlist/Refactor-Helper branch July 7, 2021 19:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Playlist performance improvements
3 participants