Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Playlist performance improvements #3855

Closed
iccub opened this issue Jun 28, 2021 · 1 comment · Fixed by #3781
Closed

Playlist performance improvements #3855

iccub opened this issue Jun 28, 2021 · 1 comment · Fixed by #3781
Assignees
@Brandon-T
Labels
enhancement Epic: Playlist QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.29

Comments

@iccub
Copy link
Contributor

iccub commented Jun 28, 2021

Not a bug, but Brandon wanted to potentially improve performance of playlists, especially on slow networks.
@iccub iccub added this to the 1.28 milestone Jun 28, 2021
@iccub iccub mentioned this issue Jun 28, 2021
Merged
7 tasks
@iccub iccub modified the milestones: 1.28, 1.29 Jun 29, 2021
Brandon-T added a commit that referenced this issue Jul 7, 2021
@Brandon-T
Fix #3855: Small Refactor of Playlist Helper (#3781)
47e2912 
* Another performance improvement for playlist.
* Refactoring code to make it clearer.
* Removing access of WKScriptMessage for logging (not sure if this will fix a possible script crash in WebKit).
@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.5 running 1.29(21.07.20.16)

Verification passed on iPhone 7+ with iOS 14.5.1 running 1.29(21.07.20.16)

Verification passed on iPad Pro with iOS 14.6 running 1.29(21.07.20.16)

@kjozwiak kjozwiak mentioned this issue Aug 10, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Brandon-T Brandon-T

Labels
enhancement Epic: Playlist QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.29
Development

Successfully merging a pull request may close this issue.

Fix #3855: Small Refactor of Playlist Helper brave/brave-ios
3 participants
@Brandon-T @iccub @srirambv