Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #3763: Update initial height of menu when page actions are visible #3767

Merged
merged 1 commit into from
Jun 10, 2021

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Jun 9, 2021

Summary of Changes

This pull request fixes #3763

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

On iPhone only

  • Open menu on NTP, height should be the same as previous versions
  • Visit a web page
  • Open menu, verify it is taller and you can access "Share to…" without scrolling

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson added this to the 1.27 milestone Jun 9, 2021
@kylehickinson kylehickinson requested a review from a team June 9, 2021 20:17
@kylehickinson kylehickinson merged commit eb911a3 into development Jun 10, 2021
@kylehickinson kylehickinson deleted the menu-height branch June 10, 2021 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase initial height of menu when page actions are visible
3 participants