Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Increase initial height of menu when page actions are visible #3763

Closed
kylehickinson opened this issue Jun 9, 2021 · 3 comments · Fixed by #3767
Closed

Increase initial height of menu when page actions are visible #3763

kylehickinson opened this issue Jun 9, 2021 · 3 comments · Fixed by #3767
Assignees
@kylehickinson
Labels
enhancement Epic: UI/UX iPhone-specific QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.27

Comments

@kylehickinson
Copy link
Collaborator

We should increase the height of the current menu when the user is tapping the menu button while browsing a web page so that the share button is immediately tappable without scrolling
@kylehickinson kylehickinson added this to the 1.27 milestone Jun 9, 2021
@kylehickinson kylehickinson self-assigned this Jun 9, 2021
kylehickinson added a commit that referenced this issue Jun 9, 2021
@kylehickinson
Fix #3763: Update initial height of menu when page actions are visible
0cbcb07
@kylehickinson kylehickinson mentioned this issue Jun 9, 2021
Merged
7 tasks
@kylehickinson
Copy link
Collaborator Author

kylehickinson commented Jun 9, 2021 •
edited
Loading

I've labeled it iPhone-specific but it could technically happen on an iPad if you are using Brave while multitasked and Brave is the smaller window where the pan modal would appear even on iPad

kylehickinson added a commit that referenced this issue Jun 10, 2021
@kylehickinson
Fix #3763: Update initial height of menu when page actions are visible (
eb911a3 
#3767)
kylehickinson added a commit that referenced this issue Jun 10, 2021
@kylehickinson
Fix #3763: Update initial height of menu when page actions are visible (
e9ea39d 
#3767)
@kjozwiak
Copy link
Member

kjozwiak commented Jun 11, 2021 •
edited
Loading

Verification PASSED on iPhone 11 running iOS 14.6 using 1.27 (21.6.10.21):

1.26 (21.5.28.14) 1.27 (21.6.10.21)
IMG_3703 IMG_3701
IMG_3704 IMG_3702

@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.5 running 1.27(21.6.10.21)

  • Verified on normal NTP menu height is same as before
  • Verified on a page menu height is increased and share button is visible when menu is opened
Menu.Height.MP4

@kylehickinson kylehickinson mentioned this issue Jun 11, 2021
Closed
@kjozwiak kjozwiak mentioned this issue Jun 22, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
enhancement Epic: UI/UX iPhone-specific QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.27
Development

Successfully merging a pull request may close this issue.

Fix #3763: Update initial height of menu when page actions are visible brave/brave-ios
3 participants
@kylehickinson @kjozwiak @srirambv