Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #2908: Selecting a single SE doesn't show up in quick search engine list #3037

Merged
merged 1 commit into from
Nov 17, 2020
Merged

Fix #2908: Selecting a single SE doesn't show up in quick search engine list #3037

merged 1 commit into from
Nov 17, 2020

Conversation

soner-yuksel
Copy link
Contributor

@soner-yuksel soner-yuksel commented Nov 13, 2020 •
edited by iccub
Loading

Adding Quick Engine Search Bar If the only selected quick engine is not the default engine

Summary of Changes

This pull request fixes #2908

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Load Brave Browser and Press Settings - Search Engines from Menu
  • Choose a standard search engine and enable only one search engine
  • Start Typing in URL bar and check quick search engine toolbar is shown

Screenshots:

Issue 2908

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

iccub
iccub approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job on cleaning up the old code

@iccub iccub merged commit 6881727 into development Nov 17, 2020
@iccub iccub deleted the quick-searchengine-fix branch November 17, 2020 12:05
@soner-yuksel soner-yuksel added this to the 1.23 milestone Dec 2, 2020
@soner-yuksel soner-yuksel self-assigned this Dec 4, 2020
@kylehickinson kylehickinson removed this from the 1.23 milestone Feb 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iccub iccub iccub approved these changes

@kylehickinson kylehickinson kylehickinson approved these changes

@Brandon-T Brandon-T Awaiting requested review from Brandon-T

Assignees

@soner-yuksel soner-yuksel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Selecting a single SE doesn't show up in quick search engine list
3 participants
@soner-yuksel @kylehickinson @iccub