Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Selecting a single SE doesn't show up in quick search engine list #2908

Closed
srirambv opened this issue Sep 28, 2020 · 1 comment · Fixed by #3037
Closed

Selecting a single SE doesn't show up in quick search engine list #2908

srirambv opened this issue Sep 28, 2020 · 1 comment · Fixed by #3037
Assignees
@soner-yuksel
Labels
bug Epic: Settings QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.23

Comments

@srirambv
Copy link
Contributor

Description:

Selecting a single SE doesn't show up in quick search engine list

Steps to Reproduce

  1. Set DDG as default SE
  2. Enable only google in quick search engine list
  3. Open tab and start typing, no quick search engine strip is shown above keyboard
  4. Enable a second SE, start typing in URL bar, quick search engine strip is shown

Actual result:
Selecting a single SE doesn't show up in quick search engine list

Expected result:
Should show quick SE strip even if only one SE is enabled

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.20

Device details:
All

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information
@soner-yuksel soner-yuksel self-assigned this Nov 13, 2020
@soner-yuksel soner-yuksel mentioned this issue Nov 13, 2020
Merged
7 tasks
@iccub iccub added this to the 1.23 milestone Nov 17, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Feb 2, 2021

Verification PASSED on iPad Air (3rd Gen) on iOS 14.3 using the following build:

1.23 (21.1.28.17)
  • ensured that both the default and selected Quick-Search SE are appearing via possible search options when Show Search Suggestions is disabled and ensured both are working as expected when selected
Suggestions Disabled Suggestions Enabled
IMG_0185 IMG_0187
IMG_0188 IMG_0186

Verification PASSED on iPad Mini 4 on iOS 13.7 using the following build:

1.23 (21.1.28.17)
  • ensured that both the default and selected Quick-Search SE are appearing via possible search options when Show Search Suggestions is disabled and ensured both are working as expected when selected
Suggestions Disabled Suggestions Enabled
IMG_0435 IMG_0438
IMG_0436 IMG_0437

Verification PASSED on iPhone 11 on iOS 14.4 using the following build:

1.23 (21.1.28.17)
  • ensured that both the default and selected Quick-Search SE are appearing via possible search options when Show Search Suggestions is disabled and ensured both are working as expected when selected
Suggestions Disabled Suggestions Enabled
IMG_3523 IMG_3525
IMG_3524 IMG_3526

Verification PASSED on iPhone 6+ on iOS 12.4.1 using the following build:

1.23 (21.1.28.17)
  • ensured that both the default and selected Quick-Search SE are appearing via possible search options when Show Search Suggestions is disabled and ensured both are working as expected when selected
Suggestions Disabled Suggestions Enabled
IMG_0094 IMG_0096
IMG_0095 IMG_0097

@kjozwiak kjozwiak mentioned this issue Feb 22, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@soner-yuksel soner-yuksel

Labels
bug Epic: Settings QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.23
Development

Successfully merging a pull request may close this issue.

Fix #2908: Selecting a single SE doesn't show up in quick search engine list brave/brave-ios
4 participants
@kjozwiak @soner-yuksel @iccub @srirambv