This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #511: Youtube ads #2655
Merged
Fix #511: Youtube ads #2655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iccub
suggested changes
Jun 22, 2020
| let isPrivateBrowsing = PrivateBrowsingManager.shared.isPrivateBrowsing | ||
|
|
There was a problem hiding this comment.
Can you add a comment referencing the ticket we are fixing?
I think we should use this old ticket for it
#511
| let isPrivateBrowsing = PrivateBrowsingManager.shared.isPrivateBrowsing | ||
|
|
||
| if url.baseDomain == "youtube.com" { |
There was a problem hiding this comment.
the WKNavDelegate getting bigger and bigger :(
Nothing to do now, but if we add another site specific hack for adblocking we should abstract it somewhere, maybe in Tab or in userScriptManager itself
iccub
added
blocked
|
Unblocking this, turns out the script works well, no more adjustments are needed. |
Brandon-T
force-pushed
the
feature/AdblockJS
branch
from
c279ad8
to
bb984ae
Compare
iccub
suggested changes
Jul 3, 2020
Brandon-T
force-pushed
the
feature/AdblockJS
branch
from
bb984ae
to
d3ff3e0
Compare
iccub
approved these changes
Jul 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Added Javascript injection into the
MainFrameonly (same as Desktop).. to block youtube ads. The JS is injected into EVERY page and not just the youtube domain which can come in multiple forms:youtube.com,youtu.be, etc..If we want it only on youtube domain, we can add it whenever. Just let me know.
This pull request fixes #511
Submitter Checklist:
NSLocalizableString()Test Plan:
Screenshots:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement