Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Youtube pre-roll ads are not blocked #511

Closed
srirambv opened this issue Nov 30, 2018 · 5 comments · Fixed by #2655
Closed

Youtube pre-roll ads are not blocked #511

srirambv opened this issue Nov 30, 2018 · 5 comments · Fixed by #2655

Comments

@srirambv
Copy link
Contributor

Description:

Youtube pre-rol ads are not blocked

Steps to Reproduce

  1. Install 1.7 (18.11.30.3)
  2. Watch a video on YT in a new tab
  3. Open a new tab and visit YT and play a random video
  4. After 2-3 videos played on the second tab, preroll ad shows up

Actual result:
image from ios

Expected result:
Should block all pre-roll ads

Reproduces how often: [Easily reproduced, Intermittent Issue]
Intermittent happened twice but not continuous

Brave Version:
1.7 (18.11.30.3)

Device details:
iPhone 7+ (IOS 12.1)

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@srirambv srirambv changed the title Youtube pre-rol ads are not blocked Youtube pre-roll ads are not blocked Nov 30, 2018
@kylehickinson
Copy link
Collaborator

Please re-test with upcoming beta

@jhreis
Copy link
Contributor

jhreis commented Mar 18, 2019

Closing this due to age, and lack of activity. If this is still an issue, please refile.

@jhreis jhreis closed this as completed Mar 18, 2019
@jhreis
Copy link
Contributor

jhreis commented Mar 22, 2019

Apparently still an issue, so reopening.

@iccub
Copy link
Contributor

iccub commented Jun 22, 2020

Putting it to 1.19 for time being, we consider making 1.18.1 hotfix for it

@srirambv
Copy link
Contributor Author

srirambv commented Jul 6, 2020

Verification passed on iPhone 7+ with iOS 13.5.1 running 1.18.1(20.07.03.15)

  • Verified steps from issue description
  • Verified no ads shown on a normal tab
  • Verified no ads shown on a private tab
  • Verified opening a link via the context menu in normal/private tab doesn't show an ad
  • Verified on both clean install and upgrade scenario

Verification passed on iPhone XR with iOS 13.5 running 1.18.1(20.07.03.15)

  • Verified steps from issue description
  • Verified no ads shown on a normal tab
  • Verified no ads shown on a private tab
  • Verified opening a link via the context menu in normal/private tab doesn't show an ad
  • Verified on both clean install and upgrade scenario

Verification passed on iPhone 6 with iOS 12.4.7 running 1.18.1(20.07.03.15)

  • Verified steps from issue description
  • Verified no ads shown on a normal tab
  • Verified no ads shown on a private tab
  • Verified opening a link via the context menu in normal/private tab doesn't show an ad
  • Verified on both clean install and upgrade scenario

Verification passed on iPad Pro with iOS 12.4.5 running 1.18.1(20.07.03.15)

  • Verified steps from issue description
  • Verified no ads shown on a normal tab
  • Verified no ads shown on a private tab
  • Verified opening a link via the context menu in normal/private tab doesn't show an ad
  • Verified on both clean install and upgrade scenario

Verification passed on iPad Pro with iOS 13.6
running 1.18.1(20.07.03.15)

  • Verified steps from issue description
  • Verified no ads shown on a normal tab
  • Verified no ads shown on a private tab
  • Verified opening a link via the context menu in normal/private tab doesn't show an ad
  • Verified on both clean install and upgrade scenario

Logged #2698 as follow up

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants