This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #2536, Fix #2527: Update Brave Rewards lib to include ads payout fix #2537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylehickinson
added
the
blocked
|
Confirmations logging is crashing therefore blocking this merge until a fix is in place |
Brandon-T
approved these changes
May 12, 2020
|
Since I am going to end up pulling changes to add ICU/ads fixes I will close this PR and open a new one with everything |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This pull request fixes #2536
This pull request fixes #2527
Related PRs from brave-core:
brave/brave-core#5495
brave/brave-core#5485
Submitter Checklist:
NSLocalizableString()Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement