-
Notifications
You must be signed in to change notification settings - Fork 873
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds recovery path for may payout problem #5495
Conversation
d68cbcf
to
8fd7e4c
Compare
@@ -34,7 +34,7 @@ const char kUseRewardsStagingServer[] = "brave.rewards.use_staging_server"; | |||
const char kStatePromotionLastFetchStamp[] = | |||
"brave.rewards.promotion_last_fetch_stamp"; | |||
const char kStatePromotionCorruptedMigrated[] = | |||
"brave.rewards.promotion_corrupted_migrated"; | |||
"brave.rewards.promotion_corrupted_migrated2"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we can just update this to 2 as we do the same thing that we do with version 1 and more
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
CI was aborted on windows, restarting |
Verification PASSED on
|
Resolves brave/brave-browser#9684
You can find diagram of what we do here https://github.com/brave/rewards/blob/master/monodraw/may_ads_payout_recovery.svg
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
plan 1:
unblinded_tokens
table. Change change status ofpromotion
to 1 andcreds_batch
status to 3. Set[]
forpublic_keys
in promotion tableplan 2:
promotion
to 1 andcreds_batch
status to 3. Overridesigned_creds
value withblinded_creds
value./promotions/reportclobberedclaims
promotion
has status 6 andcreds_batch
has status 5Reviewer Checklist:
After-merge Checklist:
changes has landed on.