Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #2401: Add disabled states for tips & monthly contributions #2409

Merged
merged 1 commit into from
Mar 24, 2020

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Mar 17, 2020

Summary of Changes

This pull request fixes #2401

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Open Rewards Settings
  • Verify "View Details" button visible while rewards is enabled
  • Verify image + label appear when rewards is disabled

Screenshots:

Simulator Screen Shot - iPhone 11 Pro - 2020-03-17 at 12 31 11

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set milestone before merging

@kylehickinson kylehickinson merged commit c71738b into development Mar 24, 2020
@kylehickinson kylehickinson deleted the disabled-tips branch March 24, 2020 20:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

monthly contributions panel still editable when BR is off
2 participants