Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

monthly contributions panel still editable when BR is off #2401

Closed
LaurenWags opened this issue Mar 9, 2020 · 1 comment · Fixed by #2409
Closed

monthly contributions panel still editable when BR is off #2401

LaurenWags opened this issue Mar 9, 2020 · 1 comment · Fixed by #2409

Comments

@LaurenWags
Copy link
Member

Description:

Monthly Contributions panel was introduced on iOS with #2218

When you toggle BR off, Monthly Contributions pane is still displayed on the Rewards section and is still editable. Probably makes sense to have this panel behave as it does on desktop - when you turn off BR on desktop, Monthly Contributions panel is still displayed but is uneditable and has some info text.

Steps to Reproduce

  1. Enable BR on 1.15
  2. Toggle BR off.

Actual result:
Monthly Contributions panel still has the 'View Details' link that can be accessed. Once you open that link, you can remove monthly recurring tips.

IMG_BFDFEA567C5E-1

Expected result:
Something similar to what Desktop has, but should probably check with design/product on if wording should be the same.
Screen Shot 2020-03-09 at 3 40 43 PM

Reproduces how often: [Easily reproduced, Intermittent Issue]
easily

Brave Version:
1.15 (20.03.05.14)

Device details:
iPad 5th Gen iOS12

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@LaurenWags
Copy link
Member Author

LaurenWags commented May 5, 2020

Verification passed on iPad 5th Gen with iOS 12 running 1.16 (20.05.05.12)

  • Verified STR from description
    iOS12iPad-RewardsOff

Verification passed on iPad mini with iOS 13 running 1.16 (20.05.05.12)

  • Verified STR from description
    iOS13iPad-RewardsOff

Verification PASSED on iPhone 11 iOS 13.4.1 & iPhone 6s+ iOS 12.4.1 using the following build:

1.16 (20.05.04.12)
iPhone 11 iOS 13.4.1 iPhone 6s+ iOS 12.4.1
IMG_0063 IMG_0016

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.