Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Ref #1656: Update balance on claim grant after tokens are fetched #1902

Merged
merged 1 commit into from
Nov 5, 2019

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Nov 5, 2019

This also fixes the bug where promos sometimes mess up when claiming them during publisher list load

Summary of Changes

This pull request references issue #1656

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Claim a grant
  • Wait on panel
  • Balance should update after 5s (if fetched tokens retry succeeds)

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

@kylehickinson kylehickinson merged commit bf0f93a into development Nov 5, 2019
@kylehickinson kylehickinson deleted the balance-update branch November 5, 2019 19:12
iccub pushed a commit to iccub/brave-ios that referenced this pull request Nov 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants