Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add support for claiming a grants #1656

Closed
kylehickinson opened this issue May 15, 2019 · 4 comments
Closed

Add support for claiming a grants #1656

kylehickinson opened this issue May 15, 2019 · 4 comments
Assignees
Labels
blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue enhancement Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone

Comments

@kylehickinson
Copy link
Collaborator

When a grant is available the user can claim it on the settings screen (or a notifications).

This needs to be integrated from both points (solveGrantCaptcha)

No expiration date when claiming ads earnings in the grant claim screen

Blocked by brave/brave-core#3294

@kylehickinson kylehickinson changed the title Add support for claiming a grant on the settings screen Add support for claiming a grants May 15, 2019
@tmancey
Copy link
Collaborator

tmancey commented Aug 28, 2019

@kylehickinson can you please raise a ticket in brave-browser so we can get this ticket unblocked

@tmancey
Copy link
Collaborator

tmancey commented Oct 3, 2019

@kylehickinson are we still blocked (see previous comment)

@kylehickinson
Copy link
Collaborator Author

@tmancey Technically, if we want to have a real grant flow implemented, we still need the dev environment (brave/brave-core#3294) which isn't done and so blocked

If we don't care about this and are just going to wait until virtualized grants, then this maybe can be closed in favour of #1654

@anthonypkeane anthonypkeane transferred this issue from brave/brave-rewards-ios Oct 15, 2019
@anthonypkeane anthonypkeane added this to the 1.13 milestone Oct 15, 2019
@kylehickinson kylehickinson added blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue release-notes/exclude enhancement labels Oct 15, 2019
@kylehickinson kylehickinson self-assigned this Oct 29, 2019
kylehickinson added a commit that referenced this issue Nov 4, 2019
Fix #1654, Fix #1656, Fix #1861: Add support for claiming virtual grants
@srirambv
Copy link
Contributor

srirambv commented Nov 5, 2019

  • Verification passed on iPhone XR with iOS 13.2 running 1.13(19.11.4.20)
  • Verification passed on iPhone 7+ with iOS 13.2 running 1.13(19.11.4.20)
  • Verification passed on iPhone 6 with iOS 12.4 running 1.13(19.11.4.20)
  • Verification passed on iPad Pro with iOS 13.2 running 1.13(19.11.4.20)
  • Verification passed on iPad Pro with iOS 12.4 running 1.13(19.11.4.20)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue enhancement Epic: Rewards QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Development

No branches or pull requests

4 participants